[webkit-reviews] review granted: [Bug 220235] [WASM-References] Fix data section parsing and add more tests from ref-types : [Attachment 416931] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted  review:
Bug 220235: [WASM-References] Fix data section parsing and add more tests from
ref-types
https://bugs.webkit.org/show_bug.cgi?id=220235

Attachment 416931: Patch

https://bugs.webkit.org/attachment.cgi?id=416931&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 416931
  --> https://bugs.webkit.org/attachment.cgi?id=416931
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416931&action=review

r=me with comment.

> Source/JavaScriptCore/wasm/WasmSectionParser.cpp:747
> +	   const char* errorMessage = Options::useWebAssemblyReferences() ? "th
Data segment's flag" : "th Data segment's index";

I think we should just throw an error with `"th Data segment's flag"`.