[webkit-reviews] review granted: [Bug 220210] [LFC Display] Give display boxes a parent pointer : [Attachment 416866] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 2 20:09:38 PST 2021
zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 220210: [LFC Display] Give display boxes a parent pointer
https://bugs.webkit.org/show_bug.cgi?id=220210
Attachment 416866: Patch
https://bugs.webkit.org/attachment.cgi?id=416866&action=review
--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 416866
--> https://bugs.webkit.org/attachment.cgi?id=416866
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=416866&action=review
> Source/WebCore/display/css/DisplayBox.h:73
> + ContainerBox* parent() const { return m_parent; }
I usually do a const and a non-const version of getters like this (unless you
really only need a const ContainerBox* parent())
More information about the webkit-reviews
mailing list