[webkit-reviews] review granted: [Bug 220179] Share meta refresh logic : [Attachment 416822] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 220179: Share meta refresh logic
https://bugs.webkit.org/show_bug.cgi?id=220179

Attachment 416822: Patch

https://bugs.webkit.org/attachment.cgi?id=416822&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 416822
  --> https://bugs.webkit.org/attachment.cgi?id=416822
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416822&action=review

> Source/WebCore/ChangeLog:8
> +	   Share meta refresh logic between Document and FrameLoader.

This change is great; two copies seems silly!

Bigger picture, long ago we tried to break apart Document and Frame so they
wouldn’t be super-huge "god objects", something we got part way through and
never finished. I worry that code moving from FrameLoader to Frame and Document
starts to undo that.