[webkit-reviews] review granted: [Bug 220102] Use WeakHashSet<Page> instead of HashSet<Page*> : [Attachment 416687] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 2 14:38:30 PST 2021


Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 220102: Use WeakHashSet<Page> instead of HashSet<Page*>
https://bugs.webkit.org/show_bug.cgi?id=220102

Attachment 416687: Patch

https://bugs.webkit.org/attachment.cgi?id=416687&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 416687
  --> https://bugs.webkit.org/attachment.cgi?id=416687
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416687&action=review

> Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:173
> +    for (const auto& page :
PageGroup::pageGroup(pageGroup->identifier())->pages())

Not sure we should have the const here. For one thing, changing the settings
for a page doesn’t seem very "const".

> Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:289
> +    for (const auto& page :
PageGroup::pageGroup(pageGroup->identifier())->pages())

Ditto.

> Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:345
> +	   for (const auto& page :
PageGroup::pageGroup(pageGroup->identifier())->pages()) {
> +	       for (const auto* frame = &page.mainFrame(); frame; frame =
frame->tree().traverseNext()) {

Could omit const here too.


More information about the webkit-reviews mailing list