[webkit-reviews] review granted: [Bug 220219] [JSC] Remove unnecessary mov bytecodes when performing simple object pattern destructuring to variables : [Attachment 416885] Patch

[bugzilla-daemon at webkit.org]

Alexey Shvayka <shvaikalesh at gmail.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 220219: [JSC] Remove unnecessary mov bytecodes when performing simple
object pattern destructuring to variables
https://bugs.webkit.org/show_bug.cgi?id=220219

Attachment 416885: Patch

https://bugs.webkit.org/attachment.cgi?id=416885&action=review




--- Comment #5 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 416885
  --> https://bugs.webkit.org/attachment.cgi?id=416885
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416885&action=review

r=me, great change!

> JSTests/stress/object-pattern-simple-fast-path.js:102
> +}());

Would it be reasonable to add more tests for guards in
writableDirectBindingIfPossible()? Like `var`, global object property that is
non-writable or accessor, WithStatement?