[webkit-reviews] review granted: [Bug 222524] Restoring App Highlight crashes if no range is found. : [Attachment 421766] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 222524: Restoring App Highlight crashes if no range is found.
https://bugs.webkit.org/show_bug.cgi?id=222524

Attachment 421766: Patch

https://bugs.webkit.org/attachment.cgi?id=421766&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 421766
  --> https://bugs.webkit.org/attachment.cgi?id=421766
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421766&action=review

> Source/WebCore/Modules/highlight/AppHighlightStorage.cpp:243
> +    if (range)

what is the bool return value of this method for? If it’s “did restoration
succeed”, perhaps you should return false here?