[webkit-reviews] review granted: [Bug 222516] Blending of border-image-width should be discrete between "auto" values and other types : [Attachment 421753] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 222516: Blending of border-image-width should be discrete between "auto"
values and other types
https://bugs.webkit.org/show_bug.cgi?id=222516

Attachment 421753: Patch

https://bugs.webkit.org/attachment.cgi?id=421753&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 421753
  --> https://bugs.webkit.org/attachment.cgi?id=421753
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421753&action=review

> Source/WebCore/ChangeLog:9
> +	   got tricked by an "auto" Length returning true for Length::isZero().
So we also check that 0 values aren't

Is this a bug? Seems like returning isZero for an auto length is wrong. Did you
check why that is?

    if (isCalculated())
	return false;
    return m_isFloat ? !m_floatValue : !m_intValue;

Seems like auto should be similar to calculated. But I bet some code would
break if we made a change here.