[webkit-reviews] review granted: [Bug 222514] Length blending code should not attempt to blend for progress 0 or 1 : [Attachment 421747] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 27 09:56:14 PST 2021


Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 222514: Length blending code should not attempt to blend for progress 0 or
1
https://bugs.webkit.org/show_bug.cgi?id=222514

Attachment 421747: Patch

https://bugs.webkit.org/attachment.cgi?id=421747&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 421747
  --> https://bugs.webkit.org/attachment.cgi?id=421747
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421747&action=review

> Source/WebCore/platform/Length.cpp:315
> +    if (!progress)
> +	   return from;
> +
> +    if (progress == 1)
> +	   return to;

Could this be moved to caller/higher level? This is true for all blend
operations right?


More information about the webkit-reviews mailing list