[webkit-reviews] review granted: [Bug 222406] Render tree updates for Text node content mutations should happen during rendering update : [Attachment 421679] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 222406: Render tree updates for Text node content mutations should happen
during rendering update
https://bugs.webkit.org/show_bug.cgi?id=222406

Attachment 421679: patch

https://bugs.webkit.org/attachment.cgi?id=421679&action=review




--- Comment #16 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 421679
  --> https://bugs.webkit.org/attachment.cgi?id=421679
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421679&action=review

> Source/WebCore/dom/CharacterData.cpp:105
> -    if (is<Text>(*this) && parentNode())
> +    if (is<Text>(*this))

This doesn't seem to be mentioned in the changelog.

> Source/WebCore/editing/CompositeEditCommand.cpp:1062
> +    if (!nodes.isEmpty())
> +	   document().updateLayoutIgnorePendingStylesheets();

This is still pretty mysterious.