[webkit-reviews] review granted: [Bug 222508] Support fast/canvas/webgl/copyBufferSubData.html, fix bugs in fast/canvas/webgl/getBufferSubData-webgl1.html in Metal ANGLE on Simulator : [Attachment 421731] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 222508: Support  fast/canvas/webgl/copyBufferSubData.html, fix bugs in
fast/canvas/webgl/getBufferSubData-webgl1.html in Metal ANGLE on Simulator
https://bugs.webkit.org/show_bug.cgi?id=222508

Attachment 421731: Patch

https://bugs.webkit.org/attachment.cgi?id=421731&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 421731
  --> https://bugs.webkit.org/attachment.cgi?id=421731
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421731&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm:233
> +    if(result)

Nit: Space before (

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm:331
> +#else //Simulator should be able to support ES3, despite not supporting ios
family 4 in it's entirety.

Nit: Space after // and s/it's/its/

I'll fix these when landing.