[webkit-reviews] review granted: [Bug 222488] [LFC][Coverage] Add missing not-yet-modern-line-layout reasons : [Attachment 421701] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 26 17:37:20 PST 2021


Sam Weinig <sam at webkit.org> has granted zalan <zalan at apple.com>'s request for
review:
Bug 222488: [LFC][Coverage] Add missing not-yet-modern-line-layout reasons
https://bugs.webkit.org/show_bug.cgi?id=222488

Attachment 421701: Patch

https://bugs.webkit.org/attachment.cgi?id=421701&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 421701
  --> https://bugs.webkit.org/attachment.cgi?id=421701
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421701&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:256
> +	   stream << "unsupported SVG content";

Most of the other strings don't include the word "unsupported".

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:262
> +	   stream << "Image Map";

Inconsistent that this is capitalized.


More information about the webkit-reviews mailing list