[webkit-reviews] review granted: [Bug 222343] [GPU Process] Some DisplayList items may not be replayed back before calling getImageData() : [Attachment 421710] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 26 17:03:44 PST 2021


Tim Horton <thorton at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 222343: [GPU Process] Some DisplayList items may not be replayed back
before calling getImageData()
https://bugs.webkit.org/show_bug.cgi?id=222343

Attachment 421710: Patch

https://bugs.webkit.org/attachment.cgi?id=421710&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 421710
  --> https://bugs.webkit.org/attachment.cgi?id=421710
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421710&action=review

> Source/WebKit/ChangeLog:10
> +	   Make sure all the pending DisplayList items are pushed to the GPUP
and
> +	   submitted to RemoteImageBuffer before calling the asynchronous
method
> +	   getImageData().

Is there an assertion we could add somewhere that would have alerted us to
this?


More information about the webkit-reviews mailing list