[webkit-reviews] review granted: [Bug 222462] [REGRESSION] [MSE] WebContent/GPU process will hang when appending data under some circumstances. : [Attachment 421707] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Jean-Yves Avenard [:jya]
<jya at apple.com>'s request for review:
Bug 222462: [REGRESSION] [MSE] WebContent/GPU process will hang when appending
data under some circumstances.
https://bugs.webkit.org/show_bug.cgi?id=222462

Attachment 421707: Patch

https://bugs.webkit.org/attachment.cgi?id=421707&action=review




--- Comment #6 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 421707
  --> https://bugs.webkit.org/attachment.cgi?id=421707
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421707&action=review

r=me, with nits before landing:

> Source/WebCore/platform/MediaSample.h:79
> +    enum class UseEndTime : bool {
> +	 DoNotUse,
> +	 Use,
> +    };

StyleBot is complaining that the enum values aren't indented correctly.

> Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:64
> -    std::pair<RefPtr<MediaSample>, RefPtr<MediaSample>> divide(const
MediaTime& presentationTime) override;
> +    std::pair<RefPtr<MediaSample>, RefPtr<MediaSample>> divide(const
MediaTime& presentationTime, UseEndTime useEndTime) override;

StyleBot is complaining that the parameter name isn't needed here.