[webkit-reviews] review denied: [Bug 221253] The layout of SVGImage should force the layout for its clients : [Attachment 421628] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 221253: The layout of SVGImage should force the layout for its clients
https://bugs.webkit.org/show_bug.cgi?id=221253

Attachment 421628: Patch

https://bugs.webkit.org/attachment.cgi?id=421628&action=review




--- Comment #24 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 421628
  --> https://bugs.webkit.org/attachment.cgi?id=421628
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421628&action=review

> Source/WebCore/rendering/RenderBox.cpp:1818
> +    if (image && WTF::holds_alternative<CachedImage*>(*image) &&
WTF::get<CachedImage*>(*image)->hasSVGImage())
> +	   setNeedsLayout();

It seems wrong to trigger layout for what might just be a CSS image change.