[webkit-reviews] review granted: [Bug 222482] [git-webkit] Better logging when attempting to convert tag to identifier : [Attachment 421676] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 26 11:01:59 PST 2021


Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 222482: [git-webkit] Better logging when attempting to convert tag to
identifier
https://bugs.webkit.org/show_bug.cgi?id=222482

Attachment 421676: Patch

https://bugs.webkit.org/attachment.cgi?id=421676&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 421676
  --> https://bugs.webkit.org/attachment.cgi?id=421676
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421676&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:213
>		   raise self.Exception("Failed to find '{}' on
'{}'".format(revision, branch))

This line can be re-worded something like: "Failed to find 'r{}' on branch:
'{}'"


More information about the webkit-reviews mailing list