[webkit-reviews] review granted: [Bug 222461] [GPUP] Allow painting of GPUP hosted video from the WebContent process : [Attachment 421619] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 222461: [GPUP] Allow painting of GPUP hosted video from the WebContent
process
https://bugs.webkit.org/show_bug.cgi?id=222461

Attachment 421619: Patch

https://bugs.webkit.org/attachment.cgi?id=421619&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 421619
  --> https://bugs.webkit.org/attachment.cgi?id=421619
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421619&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:304
> +    auto status = CVPixelBufferCreateWithIOSurface(kCFAllocatorDefault,
m_surface.get(), nullptr, &rawBuffer);

Don't we want the pixel buffer to be GL/GLES compatible if possible? 

If so, see `ImageTransferSessionVT::ioSurfacePixelBufferCreationOptions`.