[webkit-reviews] review granted: [Bug 222173] Implement OpenXR port graphics binding : [Attachment 421406] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has granted Imanol Fernandez
<ifernandez at igalia.com>'s request for review:
Bug 222173: Implement OpenXR port graphics binding
https://bugs.webkit.org/show_bug.cgi?id=222173

Attachment 421406: Patch

https://bugs.webkit.org/attachment.cgi?id=421406&action=review




--- Comment #5 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 421406
  --> https://bugs.webkit.org/attachment.cgi?id=421406
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421406&action=review

> Source/WebCore/platform/xr/openxr/OpenXRExtensions.cpp:78
> +	  
reinterpret_cast<PFN_xrVoidFunction*>(&m_methods.xrGetOpenGLGraphicsRequirement
sKHR));

Use a single line here

> Source/WebCore/platform/xr/openxr/OpenXRUtils.h:30
> +typedef __eglMustCastToProperFunctionPointerType
(*PFNEGLGETPROCADDRESSPROC)(const char *proc);

Seems superweird having to add this.

Style wise the asterisk should go always next to the type, void *EGL -> void*
EGL, char *... etc

> Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:265
> +    return features;

So this is how we avoid having to create the session too early. nice! I should
have researched a bit more about it.