[webkit-reviews] review granted: [Bug 222413] [GTK][WPE] Bump libsoup3 version to 2.99.1 : [Attachment 421515] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 222413: [GTK][WPE] Bump libsoup3 version to 2.99.1
https://bugs.webkit.org/show_bug.cgi?id=222413

Attachment 421515: Patch

https://bugs.webkit.org/attachment.cgi?id=421515&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 421515
  --> https://bugs.webkit.org/attachment.cgi?id=421515
Patch

LGTM with a nit and a comment :)

View in context: https://bugs.webkit.org/attachment.cgi?id=421515&action=review

> Source/WebCore/ChangeLog:8
> +	   Use new session getters and setters instead og g_object_get/set.

Typo: og → of

> Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:113
> +    m_soupSession = adoptGRef(soup_session_new_with_options(

I guess the idea to move the initialization of “m_soupSession” here was
because now it's longer but I don't see any other reason to not keep
using the constructor initializer list syntax (and also not needing to
move the “maxConnections” and “maxConnectionsPerHost” constants, I guess?)

In this case it's not much of an issue because a GRefPtr<> is cheap to
construct with the default value, then assign to it inside the constructor
body, so feel free to land as-is =)