[webkit-reviews] review granted: [Bug 222441] Streamline decoding NSURL so it doesn't require allocating NSData and autoreleasing : [Attachment 421577] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 222441: Streamline decoding NSURL so it doesn't require allocating NSData
and autoreleasing
https://bugs.webkit.org/show_bug.cgi?id=222441

Attachment 421577: Patch

https://bugs.webkit.org/attachment.cgi?id=421577&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 421577
  --> https://bugs.webkit.org/attachment.cgi?id=421577
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421577&action=review

> Source/WTF/wtf/cocoa/NSURLExtras.mm:153
> +NSURL *URLWithData(const void* bytes, size_t length, NSURL *baseURL)

What is the reason behind using const void* here rather than const uint8_t*?
With string code, I like to be more specific if I can to avoid people
accidentally passing in UChar* to a function like this.