[webkit-reviews] review denied: [Bug 203059] Add Swift modulemap for WebKit Private APIs : [Attachment 421471] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Dean Jackson <dino at apple.com>'s
request for review:
Bug 203059: Add Swift modulemap for WebKit Private APIs
https://bugs.webkit.org/show_bug.cgi?id=203059

Attachment 421471: Patch

https://bugs.webkit.org/attachment.cgi?id=421471&action=review




--- Comment #18 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 421471
  --> https://bugs.webkit.org/attachment.cgi?id=421471
Patch

It helps to know that it was an InstallAPI failure. Generally speaking, we
cannot do much to fix incremental builds when API/SPI headers get renamed, and
an old version is still present in the file system due to incremental nature of
the build. We could and maybe should get into the habit of adding scripts to
clean those up, but we haven't yet.

This patch makes NSURLDownloadSPI.h non-private, which appears unacceptable
given its name. So InstallAPI inadvertently pointed out a real problem for
once.