[webkit-reviews] review granted: [Bug 222436] [Payment Request] log if `updateWith` is not called synchronously : [Attachment 421557] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 222436: [Payment Request] log if `updateWith` is not called synchronously
https://bugs.webkit.org/show_bug.cgi?id=222436

Attachment 421557: Patch

https://bugs.webkit.org/attachment.cgi?id=421557&action=review




--- Comment #2 from Andy Estes <aestes at apple.com> ---
Comment on attachment 421557
  --> https://bugs.webkit.org/attachment.cgi?id=421557
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421557&action=review

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:710
> +   
scriptExecutionContext()->addConsoleMessage(JSC::MessageSource::PaymentRequest,
JSC::MessageLevel::Error, makeString("updateWith() must be called synchronously
when handling \""_s, event->type(), "\"."_s));

As we discussed, I think we should change "must" to "should".