[webkit-reviews] review granted: [Bug 208351] CSSFontFace should not need its m_fontSelector data member : [Attachment 421398] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Lord <clord at igalia.com>'s
request for review:
Bug 208351: CSSFontFace should not need its m_fontSelector data member
https://bugs.webkit.org/show_bug.cgi?id=208351

Attachment 421398: Patch

https://bugs.webkit.org/attachment.cgi?id=421398&action=review




--- Comment #29 from Darin Adler <darin at apple.com> ---
Comment on attachment 421398
  --> https://bugs.webkit.org/attachment.cgi?id=421398
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421398&action=review

> Source/WebCore/css/CSSFontFace.cpp:85
> +	       source = fontFaceElement ?
makeUnique<CSSFontFaceSource>(fontFace, item.resource(), *fontFaceElement) :
> +		   makeUnique<CSSFontFaceSource>(fontFace, item.resource());

We often put the ":" at the beginning of the second line rather than the end of
the first line. Also, our coding style calls for braces when a single line
statement becomes two lines, even though it’s still only a single statement.

> Source/WebCore/css/CSSFontFaceSource.h:93
> +    WeakPtr<CSSFontSelector> m_fontSelector { nullptr }; // For remote
fonts, to orchestrate loading.

No need for nullptr, smart pointers get initialized to null without that.

> Source/WebCore/css/CSSFontFaceSource.h:97
> +    RefPtr<JSC::ArrayBufferView> m_immediateSource { nullptr };

Ditto.

> Source/WebCore/css/CSSFontFaceSource.h:100
> +    WeakPtr<SVGFontFaceElement> m_svgFontFaceElement { nullptr };

Ditto.