[webkit-reviews] review granted: [Bug 222391] Set ownership of IOSurfaces from the GPUProcess instead of the WebProcess : [Attachment 421533] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 25 09:51:17 PST 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 222391: Set ownership of IOSurfaces from the GPUProcess instead of the
WebProcess
https://bugs.webkit.org/show_bug.cgi?id=222391

Attachment 421533: Patch

https://bugs.webkit.org/attachment.cgi?id=421533&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 421533
  --> https://bugs.webkit.org/attachment.cgi?id=421533
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421533&action=review

> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=222391

Radar

> Source/WTF/wtf/PlatformHave.h:307
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000) \
> +    || (((PLATFORM(IOS) && !PLATFORM(IOS_FAMILY_SIMULATOR)) ||
PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) \
> +    || (PLATFORM(WATCHOS) && !PLATFORM(IOS_FAMILY_SIMULATOR) &&
__WATCH_OS_VERSION_MIN_REQUIRED >= 80000) \
> +    || (PLATFORM(APPLETV) && !PLATFORM(IOS_FAMILY_SIMULATOR) &&
__TV_OS_VERSION_MIN_REQUIRED >= 150000)

These are getting out of control.


More information about the webkit-reviews mailing list