[webkit-reviews] review granted: [Bug 222405] Now Playing is not working when GPUP Media is enabled : [Attachment 421506] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jean-Yves Avenard [:jya]
<jya at apple.com>'s request for review:
Bug 222405: Now Playing is not working when GPUP Media is enabled
https://bugs.webkit.org/show_bug.cgi?id=222405

Attachment 421506: Patch

https://bugs.webkit.org/attachment.cgi?id=421506&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 421506
  --> https://bugs.webkit.org/attachment.cgi?id=421506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421506&action=review

> Source/WebCore/ChangeLog:16
> +	   MediaSessionManagerCocoa::setNowPlayingInfo would have always been
called
> +	   with false (setAsNowPlayingApplication) when the GPU process was in
use.
> +	   It needed to be called at least once.
> +	   MRMediaRemoteSetCanBeNowPlayingApplication is fairly CPU intensive,
so we
> +	   ensure we only call it if no content had been played before and
never again.

This comment isn't quite accurate because we will need to call
`MRMediaRemoteSetCanBeNowPlayingApplication(true)` again if we want to become
the NowPlaying application after having called
`MRMediaRemoteSetCanBeNowPlayingApplication(false)`. 

Your code change works because we clear `m_nowPlayingInfo` if we call
`MRMediaRemoteSetCanBeNowPlayingApplication(false)`, so I think only the
comment needs too be updated.