[webkit-reviews] review granted: [Bug 222159] Avoid tree traversals to look for form and canvas elements : [Attachment 421508] Updated for trunk
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 25 00:49:34 PST 2021
Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 222159: Avoid tree traversals to look for form and canvas elements
https://bugs.webkit.org/show_bug.cgi?id=222159
Attachment 421508: Updated for trunk
https://bugs.webkit.org/attachment.cgi?id=421508&action=review
--- Comment #8 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 421508
--> https://bugs.webkit.org/attachment.cgi?id=421508
Updated for trunk
View in context: https://bugs.webkit.org/attachment.cgi?id=421508&action=review
> Source/WebCore/html/HTMLFormElement.cpp:912
> + if (!parentElement ||
!parentElement->inclusiveAncestorStates().contains(AncestorState::Form)) {
> + ASSERT(!ancestorsOfType<HTMLFormElement>(startElement).first());
Maybe you should make ancestorsOfType and pals to do these checks (based on the
type obv) so all future code benefits too.
More information about the webkit-reviews
mailing list