[webkit-reviews] review granted: [Bug 222404] Optimize the code to check if an element delegates focus to its shadow root or not : [Attachment 421502] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 24 22:38:34 PST 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 222404: Optimize the code to check if an element delegates focus to its
shadow root or not
https://bugs.webkit.org/show_bug.cgi?id=222404

Attachment 421502: Patch

https://bugs.webkit.org/attachment.cgi?id=421502&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 421502
  --> https://bugs.webkit.org/attachment.cgi?id=421502
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421502&action=review

> Source/WebCore/dom/Node.h:554
> +	   DelegatesFocusToShadowRoot = 1 << 27,

If a node DelegatesFocusToShadowRoot, does it already have rare data? If so,
could we put this bit in rare data?


More information about the webkit-reviews mailing list