[webkit-reviews] review granted: [Bug 222344] [Cocoa] Web Inspector: expose the extension host that is used to load _WKInspectorExtension tabs : [Attachment 421483] Patch v2.1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 24 17:50:19 PST 2021


Devin Rousso <drousso at apple.com> has granted BJ Burg <bburg at apple.com>'s
request for review:
Bug 222344: [Cocoa] Web Inspector: expose the extension host that is used to
load _WKInspectorExtension tabs
https://bugs.webkit.org/show_bug.cgi?id=222344

Attachment 421483: Patch v2.1

https://bugs.webkit.org/attachment.cgi?id=421483&action=review




--- Comment #6 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 421483
  --> https://bugs.webkit.org/attachment.cgi?id=421483
Patch v2.1

View in context: https://bugs.webkit.org/attachment.cgi?id=421483&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKInspectorExtensionHost.h:66
> + at property (nonatomic, readonly) WKWebView *extensionHostWebView;

NIT: It seems a bit redundant to have `extensionHost` in the name given that
this protocol already has that in the name.  If this is ObjC convention tho
feel free to ignore :)

Also, seeing as how this is the Web Inspector `WKWebView`, should we maybe just
call it as such (e.g. `inspectorWebView`) rather than that being somewhat
implicit or explained in the discussion?


More information about the webkit-reviews mailing list