[webkit-reviews] review granted: [Bug 222370] [ews-build.webkit.org] Compute identifiers locally : [Attachment 421474] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 24 17:48:09 PST 2021

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 222370: [ews-build.webkit.org] Compute identifiers locally

Attachment 421474: Patch


--- Comment #10 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 421474
  --> https://bugs.webkit.org/attachment.cgi?id=421474

View in context: https://bugs.webkit.org/attachment.cgi?id=421474&action=review

r+ with comments.

> Tools/CISupport/ews-build/steps.py:171
> +class FetchBranches(shell.ShellCommand):

Would be good to add uni-tests as well.

> Tools/CISupport/ews-build/steps.py:173
> +    descriptionDone = ['Update local branch information']

Can re-word as: 'Updated branch information'

> Tools/CISupport/ews-build/steps.py:177
> +    def __init__(self, **kwargs):

Do you want to have a timeout here (like 5 minutes), or use the default 20
minutes timeout?

> Tools/CISupport/ews-build/steps.py:183
> +    def start(self):

Don't need this start method. You can directly define command as a class
variable, like: command = ['git', 'fetch']

For e.g.: see CleanUpGitIndexLock.command

More information about the webkit-reviews mailing list