[webkit-reviews] review granted: [Bug 218637] Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2] : [Attachment 421397] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 24 12:18:11 PST 2021


Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 218637: Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS
14.2]
https://bugs.webkit.org/show_bug.cgi?id=218637

Attachment 421397: Patch

https://bugs.webkit.org/attachment.cgi?id=421397&action=review




--- Comment #21 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 421397
  --> https://bugs.webkit.org/attachment.cgi?id=421397
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421397&action=review

Looks good. r+

>
Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:3
21
> +    // However, there caller might supply us non-public pixel format, which
makes exhaustive checks

Should this be:
  there caller -> the caller
?

>
Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:3
22
> +    // problematic.

Can any validation be done at all? What are the consequences of failing this
validation? It's important to not expose uninitialized GPU memory, etc.


More information about the webkit-reviews mailing list