[webkit-reviews] review granted: [Bug 222241] App-bound request parameter should be passed to main resource requests not the main frame : [Attachment 421333] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted katherine_cheney at apple.com's request
for review:
Bug 222241: App-bound request parameter should be passed to main resource
requests not the main frame
https://bugs.webkit.org/show_bug.cgi?id=222241

Attachment 421333: Patch

https://bugs.webkit.org/attachment.cgi?id=421333&action=review




--- Comment #21 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 421333
  --> https://bugs.webkit.org/attachment.cgi?id=421333
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421333&action=review

r=me with nits

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2777
> +	   completionHandler({
networkSession->appBoundNavigationTestingData().hasLoadedAppBoundRequestTesting
,
networkSession->appBoundNavigationTestingData().hasLoadedNonAppBoundRequestTest
ing });

Why not:
`completionHandler(networkSession->appBoundNavigationTestingData())` ?

Am I missing something?

> Source/WebKit/Shared/NavigatingToAppBoundDomain.h:69
> +	   return {{ WTFMove(*hasLoadedAppBoundRequestTesting),
WTFMove(*hasLoadedNonAppBoundRequestTesting) }};

No need for the WTFMove() since those are booleans