[webkit-reviews] review granted: [Bug 221399] Device motion / orientation events not working in third-party iframes despite Feature-Policy allowing it : [Attachment 421412] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 221399: Device motion / orientation events not working in third-party
iframes despite Feature-Policy allowing it
https://bugs.webkit.org/show_bug.cgi?id=221399

Attachment 421412: Patch

https://bugs.webkit.org/attachment.cgi?id=421412&action=review




--- Comment #40 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 421412
  --> https://bugs.webkit.org/attachment.cgi?id=421412
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421412&action=review

> Source/WebCore/dom/DeviceOrientationAndMotionAccessController.cpp:58
> +    }

It is a bit odd to have this dual code path here.
Maybe we should always go to UIProcess if we do not have the value in the map.

> Source/WebCore/dom/DeviceOrientationAndMotionAccessController.cpp:79
> +	   m_accessStatePerOrigin.set(securityOrigin->data(), permissionState);

s/set/add

> LayoutTests/ChangeLog:9
> +	   Add layout test coverage.

It is probably worth adding tests for the two iframe behavior you mentionned
above.
This could get easily overlooked in refactorings.