[webkit-reviews] review granted: [Bug 222260] [MSE] Media segment is incorrectly dropped when using negative timestampOffset : [Attachment 421300] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jean-Yves Avenard [:jya]
<jya at apple.com>'s request for review:
Bug 222260: [MSE] Media segment is incorrectly dropped when using negative
timestampOffset
https://bugs.webkit.org/show_bug.cgi?id=222260

Attachment 421300: Patch

https://bugs.webkit.org/attachment.cgi?id=421300&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 421300
  --> https://bugs.webkit.org/attachment.cgi?id=421300
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421300&action=review

> Source/WebCore/ChangeLog:11
> +	   CoreMedia packs multiple audio frames together into a single
CMSampleBuffer, this allows for faster processing and easier insertion into the
track buffer tree.
> +	   However, per mediasoure spec [1], a frame is to be dropped according
to its start time and duration. So if only the beginning of the MediaSample was
to be dropped, we would have incorrectly dropped the lot.

Since there is a typo to fix, please wrap these overly long lines people won't
need to scroll to read the ChangeLog.

> Source/WebCore/ChangeLog:13
> +	   Audio splicing isn't done yet, but this gets us closeer to it.

s/closeer/closer/