[webkit-reviews] review granted: [Bug 222270] Implement WebXR getViewport : [Attachment 421306] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has granted Imanol Fernandez
<ifernandez at igalia.com>'s request for review:
Bug 222270: Implement WebXR getViewport
https://bugs.webkit.org/show_bug.cgi?id=222270

Attachment 421306: Patch

https://bugs.webkit.org/attachment.cgi?id=421306&action=review




--- Comment #6 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 421306
  --> https://bugs.webkit.org/attachment.cgi?id=421306
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421306&action=review

Awesome job, thanks!

> Source/WebCore/Modules/webxr/WebXRSession.cpp:313
> +    // Only immersive sessions support viewport scaling.

We can probably get rid of this comment, the code bellow is self-descriptive
(let's do it in a follow up though)