[webkit-reviews] review granted: [Bug 222114] HTMLModelElement needs a renderer : [Attachment 421251] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 222114: HTMLModelElement needs a renderer
https://bugs.webkit.org/show_bug.cgi?id=222114

Attachment 421251: Patch

https://bugs.webkit.org/attachment.cgi?id=421251&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 421251
  --> https://bugs.webkit.org/attachment.cgi?id=421251
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421251&action=review

> Source/WebCore/Modules/model-element/HTMLModelElement.cpp:47
> +    , m_dataComplete { false }

Remove

> Source/WebCore/Modules/model-element/HTMLModelElement.cpp:186
> +    if (resource.loadFailedOrCanceled()) {
> +	   m_data = nullptr;
> +
> +	   m_resource->removeClient(*this);
> +	   m_resource = nullptr;
> +
> +	   if (auto* renderer = this->renderer())
> +	       renderer->updateFromElement();
> +
> +	   m_readyPromise->reject(Exception { NetworkError });
> +    } else {
> +	   m_dataComplete = true;
> +
> +	   m_resource->removeClient(*this);
> +	   m_resource = nullptr;
> +
> +	   if (auto* renderer = this->renderer())
> +	       renderer->updateFromElement();
> +
> +	   m_readyPromise->resolve(*this);
> +    }

I feel like an early return here somewhere would be nicer. Share the common
bits in a lambda.

> Source/WebCore/Modules/model-element/HTMLModelElement.h:75
> +    bool m_dataComplete;

{ false }
Put small things after big things to minimize padding.