[webkit-reviews] review granted: [Bug 222223] Preserve information about the origin of the app highlight request : [Attachment 421229] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 222223: Preserve information about the origin of the app highlight request
https://bugs.webkit.org/show_bug.cgi?id=222223

Attachment 421229: Patch

https://bugs.webkit.org/attachment.cgi?id=421229&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 421229
  --> https://bugs.webkit.org/attachment.cgi?id=421229
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421229&action=review

r=mews

> Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:350
> +    void storeAppHighlight(WebCore::AppHighlight&) const final;

Nit - IMO, it's a tad strange for this to take a AppHighlight lvalue reference
here, since it's not clear from the name (`storeAppHighlight`) that the method
will additionally mutate the given highlight data.

I think this might be better as an rvalue reference instead
(WebCore::AppHighlight&&), with `WTFMove`-ing to plumb the highlight along
through the client layer, since none of the apparent call sites seem to require
the passed-in AppHighlight afterwards.