[webkit-reviews] review requested: [Bug 222252] [Cocoa] Web Inspector: add support for receiving Web Extension events via _WKInspectorExtensionDelegate : [Attachment 421217] Patch v2.0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 22 11:52:42 PST 2021


BJ Burg <bburg at apple.com> has asked  for review:
Bug 222252: [Cocoa] Web Inspector: add support for receiving Web Extension
events via _WKInspectorExtensionDelegate
https://bugs.webkit.org/show_bug.cgi?id=222252

Attachment 421217: Patch v2.0

https://bugs.webkit.org/attachment.cgi?id=421217&action=review




--- Comment #7 from BJ Burg <bburg at apple.com> ---
Created attachment 421217

  --> https://bugs.webkit.org/attachment.cgi?id=421217&action=review

Patch v2.0

New patch addresses failures #1 and #2. Bumping major patch number because this
revised patch changes the lifecycle for WebInspectorUIExtensionControllerProxy
such that we can do |strongThis = makeRef(*this)| in completion handlers


More information about the webkit-reviews mailing list