[webkit-reviews] review granted: [Bug 222101] HTMLCanvasElement::copiedImage() contains old image with GPU Process on : [Attachment 421185] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 222101: HTMLCanvasElement::copiedImage() contains old image with GPU
Process on
https://bugs.webkit.org/show_bug.cgi?id=222101

Attachment 421185: Patch

https://bugs.webkit.org/attachment.cgi?id=421185&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 421185
  --> https://bugs.webkit.org/attachment.cgi?id=421185
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421185&action=review

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:350
> +void
RemoteRenderingBackend::getShareableBitmapForImageBuffer(WebCore::RenderingReso
urceIdentifier identifier, WebCore::PreserveResolution preserveResolution,
CompletionHandler<void(ShareableBitmap::Handle&&)>&& completionHandler)

Does this need to use a CompletionHandler, since it's synchronous?