[webkit-reviews] review granted: [Bug 222050] [git-webkit] Failure to retrieve commit in EWS : [Attachment 420854] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 19 17:40:40 PST 2021


Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 222050: [git-webkit] Failure to retrieve commit in EWS
https://bugs.webkit.org/show_bug.cgi?id=222050

Attachment 420854: Patch

https://bugs.webkit.org/attachment.cgi?id=420854&action=review




--- Comment #12 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 420854
  --> https://bugs.webkit.org/attachment.cgi?id=420854
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420854&action=review

> Tools/CISupport/ews-build/loadConfig.py:53
> +    for variable in ['GITHUB_COM_USERNAME', 'GITHUB_COM_ACCESS_TOKEN']:

I prefer GITHUB_USERNAME everywhere for better readability, but that’s not a
big deal.


More information about the webkit-reviews mailing list