[webkit-reviews] review granted: [Bug 222206] Add back old media playback API but deprecated : [Attachment 421041] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 19 15:14:42 PST 2021


Tim Horton <thorton at apple.com> has granted katherine_cheney at apple.com's request
for review:
Bug 222206: Add back old media playback API but deprecated
https://bugs.webkit.org/show_bug.cgi?id=222206

Attachment 421041: Patch

https://bugs.webkit.org/attachment.cgi?id=421041&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 421041
  --> https://bugs.webkit.org/attachment.cgi?id=421041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421041&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:529
> +- (void)pauseAllMediaPlayback:(void (^_Nullable)(void))completionHandler
WK_API_DEPRECATED_WITH_REPLACEMENT("pauseAllMediaPlaybackWithCompletionHandler"
, macos(WK_MAC_TBA), ios(WK_IOS_TBA));

I think the deprecation macros take ranges, which in your case are perhaps like
macos(WK_MAC_TBA, WK_MAC_TBA)?


More information about the webkit-reviews mailing list