[webkit-reviews] review granted: [Bug 222201] CrashTracer: com.apple.WebKit.Networking at WebKit: WTF::Detail::CallableWrapper<WebKit::PrivateClickMeasurementManager::firePendingAttributionRequests() : [Attachment 421033] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 19 14:54:56 PST 2021


Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 222201: CrashTracer: com.apple.WebKit.Networking at WebKit:
WTF::Detail::CallableWrapper<WebKit::PrivateClickMeasurementManager::firePendin
gAttributionRequests()
https://bugs.webkit.org/show_bug.cgi?id=222201

Attachment 421033: Patch

https://bugs.webkit.org/attachment.cgi?id=421033&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 421033
  --> https://bugs.webkit.org/attachment.cgi?id=421033
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421033&action=review

> Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:57
> +    , m_networkProcess(makeWeakPtr(networkProcess))

This is probably the right architecture -- we don't own the network process
(i.e. we shouldn't be the thing keeping it alive), so a weakptr makes sense.

> Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:-426
> -    return m_networkSession &&
m_networkProcess->privateClickMeasurementEnabled() &&
!m_sessionID.isEphemeral();

It's a bummer that we can't figure out which of these things is the source of
the issue. Perhaps it would be useful to early return if !m_networkSession and
!m_networkProcess.


More information about the webkit-reviews mailing list