[webkit-reviews] review granted: [Bug 191390] "min-content" & "max-content" keywords should behave as initial value in block axis (but WebKit improperly treats them as the content-size) : [Attachment 420960] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 191390: "min-content" & "max-content" keywords should behave as initial
value in block axis (but WebKit improperly treats them as the content-size)
https://bugs.webkit.org/show_bug.cgi?id=191390

Attachment 420960: Patch

https://bugs.webkit.org/attachment.cgi?id=420960&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 420960
  --> https://bugs.webkit.org/attachment.cgi?id=420960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420960&action=review

> LayoutTests/ChangeLog:11
> +	   Remove test that makes now incorrect assumptions.
> +
> +	   * fast/css-intrinsic-dimensions/height-expected.html: Removed.
> +	   * fast/css-intrinsic-dimensions/height.html: Removed.

It’s great to remove tests based on incorrect assumptions. This doesn’t explain
why it’s OK to have reduced test *coverage*, though. Presumably the reason is
either that WPT has thorough testing of this that was already redundant with
this test, or that we have plenty of coverage elsewhere (but then I’d expect us
to be updating expected results for the progression).