[webkit-reviews] review granted: [Bug 222006] Web Inspector: Implement Grid Overlay "Show line names" drawing : [Attachment 420990] Patch v1.0

[bugzilla-daemon at webkit.org]

BJ Burg <bburg at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 222006: Web Inspector: Implement Grid Overlay "Show line names" drawing
https://bugs.webkit.org/show_bug.cgi?id=222006

Attachment 420990: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=420990&action=review




--- Comment #8 from BJ Burg <bburg at apple.com> ---
Comment on attachment 420990
  --> https://bugs.webkit.org/attachment.cgi?id=420990
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=420990&action=review

r=me

For posterity, please attach a screenshot showing line numbers, and line
numbers + labels.

> Source/WebCore/inspector/InspectorOverlay.cpp:1341
> +    auto addOrAppendLineNames = [&](unsigned index, Vector<String> newNames)
{

It would be clearer as "appendLineNames" since it always does an append instead
of a splice.