[webkit-reviews] review granted: [Bug 222015] [iOS][FCR] Enable the new appearance by default : [Attachment 420922] Patch

Fri Feb 19 11:07:23 PST 2021

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 222015: [iOS][FCR] Enable the new appearance by default
https://bugs.webkit.org/show_bug.cgi?id=222015

Attachment 420922: Patch

https://bugs.webkit.org/attachment.cgi?id=420922&action=review

--- Comment #9 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 420922
  --> https://bugs.webkit.org/attachment.cgi?id=420922
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420922&action=review

>
LayoutTests/fast/forms/ios/select-picker-change-and-focus-another-select.html:1
> +<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true
IOSFormControlRefreshEnabled=false ] -->

While some of these tests are no longer relevant, we should file followup bugs
to make some of these tests work using the new (refreshed) UI. This seems like
one that might potentially still be applicable? (Maybe only with a hardware
keyboard attached though)

> LayoutTests/platform/ipad/fast/forms/choose-select-option.html:1
> +<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true
IOSFormControlRefreshEnabled=false ] -->

This seems like another test that could (feasibly) be adapted to the refreshed
select UI.