[webkit-reviews] review granted: [Bug 222165] Allow to use BigInt as key identifier : [Attachment 420976] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 222165: Allow to use BigInt as key identifier
https://bugs.webkit.org/show_bug.cgi?id=222165

Attachment 420976: Patch

https://bugs.webkit.org/attachment.cgi?id=420976&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 420976
  --> https://bugs.webkit.org/attachment.cgi?id=420976
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420976&action=review

> Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.idl:53
> +    [Custom] Promise<undefined> setEncryptionKey(CryptoKey key, optional any
keyID);

I’d like to eventually make this a non-custom binding.

> Source/WebCore/bindings/js/JSRTCRtpSFrameTransformCustom.cpp:36
> +using namespace JSC;

In new code I suggest we not use "using namespace" like this.