[webkit-reviews] review granted: [Bug 222162] [JSC] Remove vm.topCallFrame storing in Baseline JIT : [Attachment 420935] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 222162: [JSC] Remove vm.topCallFrame storing in Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=222162

Attachment 420935: Patch

https://bugs.webkit.org/attachment.cgi?id=420935&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 420935
  --> https://bugs.webkit.org/attachment.cgi?id=420935
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420935&action=review

> Source/JavaScriptCore/ChangeLog:9
> +	   This patch removes vm.topCallFrame storing in Baseline JIT since
operation / slow-path-call can retrieve CallFrame* via
> +	   __builtin_frame_address or callFrame argument.

After discussing the intent of this patch with Yusuke offline, I suggest
rephrasing this as "This patch removes vm.topCallFrame storing in the Baseline
JIT for ports that can USE(BUILTIN_FRAME_ADDRESS).  Also refactored some
CommonSlowPath functions so that they can start using __builtin_frame_address
later instead of the requiring that CallFrame be passed in."