[webkit-reviews] review requested: [Bug 222161] Web Inspector: CSS Grid Inspector: use a color palette for default grid overlay colors : [Attachment 420932] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 19 00:36:25 PST 2021


Nikita Vasilyev <nvasilyev at apple.com> has asked  for review:
Bug 222161: Web Inspector: CSS Grid Inspector: use a color palette for default
grid overlay colors
https://bugs.webkit.org/show_bug.cgi?id=222161

Attachment 420932: Patch

https://bugs.webkit.org/attachment.cgi?id=420932&action=review




--- Comment #1 from Nikita Vasilyev <nvasilyev at apple.com> ---
Created attachment 420932

  --> https://bugs.webkit.org/attachment.cgi?id=420932&action=review

Patch

The palette I'm using is inspired by
https://colorbrewer2.org/#type=qualitative&scheme=Set1&n=5
but it's heavily modified to fit our requirements. The overlay lines are 1px
wide.
The Colorbrewer2 palettes are made to fill regions on the map, not to draw 1px
borders.
I increased lightness and brightness to better serve our needs.

I also made it slightly more colorblind safe (tested with Sim Daltonism
https://apps.apple.com/us/app/sim-daltonism/id693112260?mt=12).


More information about the webkit-reviews mailing list