[webkit-reviews] review granted: [Bug 222157] Minor fixes to RegExp match indices after r273086 : [Attachment 420915] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 222157: Minor fixes to RegExp match indices after r273086
https://bugs.webkit.org/show_bug.cgi?id=222157

Attachment 420915: Patch

https://bugs.webkit.org/attachment.cgi?id=420915&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 420915
  --> https://bugs.webkit.org/attachment.cgi?id=420915
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420915&action=review

r=me

> Source/JavaScriptCore/runtime/RegExpMatchesArray.h:109
> +	       indicesArray->putDirect(vm,
RegExpMatchesIndicesGroupsPropertyOffset, indicesGroups ? indicesGroups :
jsUndefined());

Can you add a test for this change?