[webkit-reviews] review granted: [Bug 222149] Create SQLite skeleton implementation for PCM fraud prevention : [Attachment 420895] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 18 18:23:14 PST 2021


Jiewen Tan <jiewen_tan at apple.com> has granted katherine_cheney at apple.com's
request for review:
Bug 222149: Create SQLite skeleton implementation for PCM fraud prevention
https://bugs.webkit.org/show_bug.cgi?id=222149

Attachment 420895: Patch

https://bugs.webkit.org/attachment.cgi?id=420895&action=review




--- Comment #3 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 420895
  --> https://bugs.webkit.org/attachment.cgi?id=420895
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420895&action=review

LGTM, r=me. Thanks for making this patch.

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:2966
> +    // FIXME: Store these in the attribution object once PCM fraud
prevention is in place.

You can refer to this radar: <rdar://problem/73582032>.

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:3017
> +    // FIXME: Use real values from the attribution object once PCM fraud
prevention is in place.

You can refer to this radar: <rdar://problem/73582032>.


More information about the webkit-reviews mailing list