[webkit-reviews] review granted: [Bug 221370] Web Inspector: Elements: show badges for CSS Grid container elements : [Attachment 420767] Patch

[bugzilla-daemon at webkit.org]

BJ Burg <bburg at apple.com> has granted Nikita Vasilyev <nvasilyev at apple.com>'s
request for review:
Bug 221370: Web Inspector: Elements: show badges for CSS Grid container
elements
https://bugs.webkit.org/show_bug.cgi?id=221370

Attachment 420767: Patch

https://bugs.webkit.org/attachment.cgi?id=420767&action=review




--- Comment #10 from BJ Burg <bburg at apple.com> ---
Comment on attachment 420767
  --> https://bugs.webkit.org/attachment.cgi?id=420767
Patch

r=me.

The code changes look good to me. At this point it's tweaking color styles. As
we discussed, the  gray on gray on gray scheme for inactive badge in an
inactive window has low contrast and doesn't look like a button. To be
consistent with our other button UI (especially scope bar), the background
color shouldn't change when the DOMTreeElement selection color goes from blue
to gray upon losing keyboard focus or window focus.

I'm open to considering a wholesale change to dim our custom buttons when
losing window focus. Even if it's a good idea, it should not be considered as
part of this button patch.