[webkit-reviews] review granted: [Bug 222007] Web Inspector: Implement Grid Overlay "Show track sizes" drawing : [Attachment 420787] Patch v1.0 - Label style adjustments and cleanup

[bugzilla-daemon at webkit.org]

BJ Burg <bburg at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 222007: Web Inspector: Implement Grid Overlay "Show track sizes" drawing
https://bugs.webkit.org/show_bug.cgi?id=222007

Attachment 420787: Patch v1.0 - Label style adjustments and cleanup

https://bugs.webkit.org/attachment.cgi?id=420787&action=review




--- Comment #12 from BJ Burg <bburg at apple.com> ---
Comment on attachment 420787
  --> https://bugs.webkit.org/attachment.cgi?id=420787
Patch v1.0 - Label style adjustments and cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=420787&action=review

r=me

> Source/WebCore/ChangeLog:9
> +	   `CSSValue`, not from the GridTrackSize as the later looses the exact
authored syntax (e.g. `14vw` is already

Nit: loses

> Source/WebCore/inspector/InspectorOverlay.cpp:1283
> +	   if (!styleRule)

IMO, it would be a programming error in .styleRulesForElement() if an empty
RefPtr<StyleRule> was included, so please add an ASSERT(styleRule) as well.